<html>
<head><meta charset="utf-8"><title>next steps · t-compiler/wg-polymorphization · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/index.html">t-compiler/wg-polymorphization</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html">next steps</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204597203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/204597203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#204597203">(Jul 21 2020 at 20:09)</a>:</h4>
<p><span class="user-mention" data-user-id="116107">@davidtwco</span> are we tracking the next steps anywhere? :P</p>



<a name="204597296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/204597296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#204597296">(Jul 21 2020 at 20:10)</a>:</h4>
<p>probably an important one is removing all <code>ParamEnv::reveal_all()</code> from codegen, and instead tracking the <code>ParamEnv</code> in the "mono item"</p>



<a name="204597346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/204597346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#204597346">(Jul 21 2020 at 20:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="119009">eddyb</span> <a href="#narrow/stream/216091-t-compiler.2Fwg-polymorphization/topic/progress.20updates/near/204597203">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116107">davidtwco</span> are we tracking the next steps anywhere? <span aria-label="stuck out tongue" class="emoji emoji-1f61d" role="img" title="stuck out tongue">:stuck_out_tongue:</span></p>
</blockquote>
<p>not anywhere that I'm aware of</p>



<a name="204598186"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/204598186" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#204598186">(Jul 21 2020 at 20:19)</a>:</h4>
<p>something simple like trying <code>layout_of(ty)</code> on various types in the MIR body and ignoring generics in <code>ty</code> if it succeeds, should work, but the lack of a correct <code>ParamEnv</code> would make it fail later (especially if e.g. it's something like <code>&amp;T</code> which only has a constant layout if <code>T: Sized</code>)</p>



<a name="205926306"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205926306" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205926306">(Aug 04 2020 at 16:07)</a>:</h4>
<p>Now that a fix for <a class="stream-topic" data-stream-id="216091" href="/#narrow/stream/216091-t-compiler.2Fwg-polymorphization/topic/tokio.20regression.20.28.2374614.29">#t-compiler/wg-polymorphization &gt; tokio regression (#74614)</a> has landed, I think the next step ought to be opening a PR to re-enable polymorphisation and then run crater - does that make sense?</p>



<a name="205927000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205927000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205927000">(Aug 04 2020 at 16:13)</a>:</h4>
<p>(I was myself surprised by the weird perf results, not of the neutral revert, but of the initial loss which didn't appear at all in the try runs IIRC ?)</p>



<a name="205927462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205927462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205927462">(Aug 04 2020 at 16:16)</a>:</h4>
<p>(most of the discrepancies between the try run and the landing perf were explained by the script-servo benchmark changing, as I understand it)</p>



<a name="205927523"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205927523" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205927523">(Aug 04 2020 at 16:17)</a>:</h4>
<p>it was definitely involved in the confusion :)</p>



<a name="205927760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205927760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205927760">(Aug 04 2020 at 16:19)</a>:</h4>
<p>it won't hurt to prepare the PR and get a try build going, at the very least since the crater queue is already long, just in case another PR slips in before yours</p>



<a name="205928983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205928983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205928983">(Aug 04 2020 at 16:30)</a>:</h4>
<p><span class="user-mention" data-user-id="116107">@davidtwco</span> what I mean is: I'm confused because the last try run results <a href="https://github.com/rust-lang/rust/pull/69749#issuecomment-660339009">GH link so you don't have to unfold 205 comments</a>, <a href="https://perf.rust-lang.org/compare.html?start=c2dbebd3d4ad21e80ef4e7535dd1e868aaad7e50&amp;end=bcc129994eb5e74186bdd0853540882aeab82516">perf.rlo results</a> show +2% on script-servo-2 while the <a href="https://github.com/rust-lang/rust/pull/69749#issuecomment-664688297">perf triage</a> mentions a <a href="https://perf.rust-lang.org/compare.html?start=734233d29771869f824d8ddbaddabb90b3b68e03&amp;end=b52522ade1f6979a35b24087dadcf5ba5c981cbe&amp;stat=instructions:u">+31% loss</a> on different incr cases ...</p>



<a name="205929356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205929356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205929356">(Aug 04 2020 at 16:34)</a>:</h4>
<p>yeah, I don't understand the incr-comp results</p>



<a name="205929478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205929478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205929478">(Aug 04 2020 at 16:35)</a>:</h4>
<p>I wonder if the perf.rlo profiling issues (with the std build) were around the same time, if it hid the regression, or if those new results are weird as well</p>



<a name="205929600"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205929600" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205929600">(Aug 04 2020 at 16:36)</a>:</h4>
<p>do crater runs run with debug assertions on?</p>



<a name="205929700"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205929700" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205929700">(Aug 04 2020 at 16:37)</a>:</h4>
<p>if so, I would like to add that when testing this <a href="https://github.com/rust-lang/rust/pull/74717#discussion_r463690015">https://github.com/rust-lang/rust/pull/74717#discussion_r463690015</a></p>



<a name="205929828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205929828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205929828">(Aug 04 2020 at 16:39)</a>:</h4>
<p>I'm preparing a PR with some small polymorphisation-related changes just now, so I'll add that change shortly.</p>



<a name="205935279"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205935279" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205935279">(Aug 04 2020 at 17:29)</a>:</h4>
<p><span class="user-mention" data-user-id="216206">@lcnr</span> <a href="https://github.com/rust-lang/rust/issues/75155">#75155</a></p>



<a name="205936281"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205936281" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205936281">(Aug 04 2020 at 17:37)</a>:</h4>
<p><span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span></p>



<a name="205936288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205936288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205936288">(Aug 04 2020 at 17:37)</a>:</h4>
<p>Also what is that? <a href="/user_uploads/4715/lxXq6tgTCPxSDt8tViNo_NWg/Screenshot-from-2020-08-04-19-37-23.png">Screenshot-from-2020-08-04-19-37-23.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/lxXq6tgTCPxSDt8tViNo_NWg/Screenshot-from-2020-08-04-19-37-23.png" title="Screenshot-from-2020-08-04-19-37-23.png"><img src="/user_uploads/4715/lxXq6tgTCPxSDt8tViNo_NWg/Screenshot-from-2020-08-04-19-37-23.png"></a></div>



<a name="205936649"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205936649" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205936649">(Aug 04 2020 at 17:41)</a>:</h4>
<p>kiljacken doesn't seem to be a member of the org ? <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="205936796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205936796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205936796">(Aug 04 2020 at 17:42)</a>:</h4>
<p>yeah</p>



<a name="205942705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205942705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205942705">(Aug 04 2020 at 18:30)</a>:</h4>
<p>They deleted their review comment which pointed out the same thing your comment did.</p>



<a name="205942744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/205942744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#205942744">(Aug 04 2020 at 18:30)</a>:</h4>
<p>I had replied to both when I fixed it and so my comment was removed.</p>



<a name="206005194"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206005194" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206005194">(Aug 05 2020 at 09:56)</a>:</h4>
<p>Re-enable PR at <a href="https://github.com/rust-lang/rust/issues/75185">#75185</a></p>



<a name="206008867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008867">(Aug 05 2020 at 10:57)</a>:</h4>
<p>Triggered crater run for it</p>



<a name="206008913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008913">(Aug 05 2020 at 10:58)</a>:</h4>
<p>A check run?</p>



<a name="206008919"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008919" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008919">(Aug 05 2020 at 10:58)</a>:</h4>
<p>We need at least build to actually trigger polymorphization, don't we?</p>



<a name="206008929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008929">(Aug 05 2020 at 10:58)</a>:</h4>
<p>I didn't realise that's what that command meant - I just copied the last (and first time) I'd run crater.</p>



<a name="206008940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008940">(Aug 05 2020 at 10:58)</a>:</h4>
<p>I assumed it was just "do the crater check"</p>



<a name="206008944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008944">(Aug 05 2020 at 10:58)</a>:</h4>
<p>Let me quickly check myself</p>



<a name="206008949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008949">(Aug 05 2020 at 10:58)</a>:</h4>
<p>Now to learn how to cancel crater runs</p>



<a name="206008954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008954">(Aug 05 2020 at 10:58)</a>:</h4>
<p>if I didn't mix something up here</p>



<a name="206008964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206008964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206008964">(Aug 05 2020 at 10:59)</a>:</h4>
<p>it looks like you're right</p>



<a name="206009060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009060">(Aug 05 2020 at 11:00)</a>:</h4>
<p>build-only is probably fine right?</p>



<a name="206009084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009084">(Aug 05 2020 at 11:00)</a>:</h4>
<p>hmm, we might actually try and run tests to check if we break anything there <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="206009112"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009112" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009112">(Aug 05 2020 at 11:00)</a>:</h4>
<p>I don't know how much longer a test build takes than a build one</p>



<a name="206009123"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009123" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009123">(Aug 05 2020 at 11:01)</a>:</h4>
<p>I guess we'll find out</p>



<a name="206009158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009158">(Aug 05 2020 at 11:01)</a>:</h4>
<p>yeah, imo let's go with test</p>



<a name="206009195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009195">(Aug 05 2020 at 11:01)</a>:</h4>
<p>If anyone reading this is thinking "this guy has no idea how to use crater, we have to stop him" and has the appropriate privileges to do so - feel free to cancel the run and start the appropriate type</p>



<a name="206009312"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009312" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009312">(Aug 05 2020 at 11:02)</a>:</h4>
<p>time to wait a few weeks I guess <span aria-label="laughter tears" class="emoji emoji-1f602" role="img" title="laughter tears">:laughter_tears:</span></p>



<a name="206009417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206009417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206009417">(Aug 05 2020 at 11:04)</a>:</h4>
<p>there are things <a href="#narrow/stream/216091-t-compiler.2Fwg-polymorphization/topic/next.20steps/near/204597296">like this</a> that we can proceed with</p>



<a name="206017500"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206017500" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206017500">(Aug 05 2020 at 12:48)</a>:</h4>
<p><span class="user-mention" data-user-id="116107">@davidtwco</span> here's some docs for you <a href="https://github.com/rust-lang/crater/blob/master/docs/bot-usage.md">https://github.com/rust-lang/crater/blob/master/docs/bot-usage.md</a> I <em>think</em> you'd only need "build-only" ? IIRC it used to build all targets including tests (but that may another option to ask for) rather than <em>running</em> the tests as well ?</p>



<a name="206017590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206017590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206017590">(Aug 05 2020 at 12:49)</a>:</h4>
<p>it'll be better to check with <span class="user-mention" data-user-id="116122">@simulacrum</span> in any case but looking at the queue there will be time to fiddle with the run's options :)</p>



<a name="206017622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206017622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206017622">(Aug 05 2020 at 12:49)</a>:</h4>
<p>I was looking at that earlier, if it builds the tests too, then <code>build-only</code> would be more appropriate - would need to check with someone from <a class="stream" data-stream-id="242791" href="/#narrow/stream/242791-t-infra">#t-infra</a>.</p>



<a name="206017735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206017735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206017735">(Aug 05 2020 at 12:50)</a>:</h4>
<p>getting miscompilations here is hard, isn't it? <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="206017782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206017782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206017782">(Aug 05 2020 at 12:51)</a>:</h4>
<p>I think it does yeah, at least I definitely remember seeing some errors in tests in some past runs we did</p>



<a name="206017794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206017794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206017794">(Aug 05 2020 at 12:51)</a>:</h4>
<p>or well, you would have to somehow accidentally mark a param as unused which isn't</p>



<a name="206022666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206022666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206022666">(Aug 05 2020 at 13:38)</a>:</h4>
<p>(just remembered that there's also getting polymorphisation to work with new symbol mangling)</p>



<a name="206038369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206038369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Emil Lauridsen <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206038369">(Aug 05 2020 at 15:41)</a>:</h4>
<p>Sorry about the permission scare yesterday! I commented before github lazy loaded the existing review comment, and then deleted before github loaded the "fixed" reply, resulting in a very confusing experience!</p>



<a name="206389970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206389970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206389970">(Aug 09 2020 at 10:55)</a>:</h4>
<p>Filed an issue about <a href="#narrow/stream/216091-t-compiler.2Fwg-polymorphization/topic/next.20steps/near/204597296">eddy's earlier suggestion in this topic</a> so we don't lose track of it - <a href="https://github.com/rust-lang/rust/issues/75327">#75327</a>.</p>



<a name="206397075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206397075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206397075">(Aug 09 2020 at 14:23)</a>:</h4>
<p>I believe <a href="https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3AA-polymorphization">these issues</a> represent the majority of the immediate issues or pending work on polymorphization.</p>



<a name="206673721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206673721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206673721">(Aug 12 2020 at 09:11)</a>:</h4>
<p><span class="user-mention silent" data-user-id="119009">eddyb</span> <a href="#narrow/stream/216091-t-compiler.2Fwg-polymorphization/topic/next.20steps/near/204597296">said</a>:</p>
<blockquote>
<p>probably an important one is removing all <code>ParamEnv::reveal_all()</code> from codegen, and instead tracking the <code>ParamEnv</code> in the "mono item"</p>
</blockquote>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> does Miri also need to change its <code>ParamEnv</code> handling?</p>



<a name="206675376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/206675376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#206675376">(Aug 12 2020 at 09:39)</a>:</h4>
<p>I think we already did that in miri, there should be no more reveal_all's in there except for static items, which can't be generic anyway</p>



<a name="208186416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/216091-t-compiler/wg-polymorphization/topic/next%20steps/near/208186416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/216091-t-compiler/wg-polymorphization/topic/next.20steps.html#208186416">(Aug 27 2020 at 07:41)</a>:</h4>
<p><span class="user-mention silent" data-user-id="124288">oli</span> <a href="#narrow/stream/216091-t-compiler.2Fwg-polymorphization/topic/next.20steps/near/206675376">said</a>:</p>
<blockquote>
<p>I think we already did that in miri, there should be no more reveal_all's in there except for static items, which can't be generic anyway</p>
</blockquote>
<p>you are right, I just checked</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>